Ridge - don't set sample_weight if no class_weight provided#4851
Merged
mblondel merged 1 commit intoscikit-learn:masterfrom Jun 22, 2015
Merged
Ridge - don't set sample_weight if no class_weight provided#4851mblondel merged 1 commit intoscikit-learn:masterfrom
mblondel merged 1 commit intoscikit-learn:masterfrom
Conversation
Member
|
You changed it in |
Member
|
Otherwise, LGTM |
Contributor
Author
|
Thanks, will have another look tonight, egads. |
add RidgeClassifier
a9f4a32 to
3193993
Compare
Contributor
Author
|
OK, note to self, don't try to push commits before the first coffee of the day 😄 Fix is now in place for both |
Member
|
CC @eickenberg (author of #3034) |
mblondel
added a commit
that referenced
this pull request
Jun 22, 2015
Ridge - don't set sample_weight if no class_weight provided
Member
|
Ok, @eickenberg seems busy. Merged. Thanks @trevorstephens! |
Contributor
Author
|
Thanks for the review @mblondel ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@mblondel fixes #4846