Skip to content

[MRG+1] Fix RFE#4496

Merged
amueller merged 1 commit intoscikit-learn:masterfrom
vmichel:rfe_feature_importances
Apr 2, 2015
Merged

[MRG+1] Fix RFE#4496
amueller merged 1 commit intoscikit-learn:masterfrom
vmichel:rfe_feature_importances

Conversation

@vmichel
Copy link
Copy Markdown
Member

@vmichel vmichel commented Apr 2, 2015

Add the possibility to use feature_importances rather than coef_ when existing, see #2121

@glouppe
Copy link
Copy Markdown
Contributor

glouppe commented Apr 2, 2015

Looks good. +1 for merge

cc @ogrisel

@landscape-bot
Copy link
Copy Markdown

Code Health
Code quality remained the same when pulling 0f0e58d on vmichel:rfe_feature_importances into 1c33a6f on scikit-learn:master.

@glouppe glouppe changed the title [MRG] Fix RFE [MRG+1] Fix RFE Apr 2, 2015
@amueller
Copy link
Copy Markdown
Member

amueller commented Apr 2, 2015

LGTM, merging.

amueller added a commit that referenced this pull request Apr 2, 2015
@amueller amueller merged commit c4b650f into scikit-learn:master Apr 2, 2015
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The forest doesn't have a fixed random seed :-/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants