BUG: Correct check for local import#4095
Merged
ogrisel merged 1 commit intoscikit-learn:masterfrom Jan 14, 2015
Merged
Conversation
Member
|
looks good to me. |
Member
|
+1 as well. Merging. Thanks for the fix @jjhelmus. |
ogrisel
added a commit
that referenced
this pull request
Jan 14, 2015
BUG: Correct check for local import
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With the move of the
check_builddirectory to__check_buildin cd74047 the comparison for displaying the error message indicating a import from the source tree that has not been build inplace was incorrect. This fixes this bug so that the INPLACE_MSG is displayed in these cases.