Skip to content

LSH forest#3980

Merged
larsmans merged 62 commits intoscikit-learn:masterfrom
larsmans:lsh-forest
Dec 18, 2014
Merged

LSH forest#3980
larsmans merged 62 commits intoscikit-learn:masterfrom
larsmans:lsh-forest

Conversation

@larsmans
Copy link
Copy Markdown
Member

#3894 in just over 80 commits. Moved some LSH-specific utility code back out of the neighbors base classes.

I just want to see if the tests work on this one.

maheshakya and others added 18 commits December 18, 2014 19:39
Removed _do_hash function.
The functionality of _do_hash is done within the _create_tree function as
a hashing function is generated for each tree and it doesn't need a separate
function.

Added _convert_to_hash function.
This will be used in the queries and insertions to convert the data point
into the integer represented by the binary hash.

Updated _generate_masks to work with cached hashes.

Changed the insert function to accpet a batch of data points(a 2D array).
Now trees and original indices are stored in lists. Tests for insert and fit
functions have been updated.

Changed safe_asarray to check_arrary.
in fit, kneighbors and radius methods, None type is not checked because
it is not an expected input.
Updated the compute distance function to use row_norms.
larsmans added a commit that referenced this pull request Dec 18, 2014
@larsmans larsmans merged commit 1081f81 into scikit-learn:master Dec 18, 2014
@larsmans larsmans deleted the lsh-forest branch December 18, 2014 18:50
@jnothman
Copy link
Copy Markdown
Member

"what's new"?

@larsmans
Copy link
Copy Markdown
Member Author

Good point. c6b2049.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants