Merged
Conversation
Removed _do_hash function. The functionality of _do_hash is done within the _create_tree function as a hashing function is generated for each tree and it doesn't need a separate function. Added _convert_to_hash function. This will be used in the queries and insertions to convert the data point into the integer represented by the binary hash. Updated _generate_masks to work with cached hashes. Changed the insert function to accpet a batch of data points(a 2D array). Now trees and original indices are stored in lists. Tests for insert and fit functions have been updated. Changed safe_asarray to check_arrary.
in fit, kneighbors and radius methods, None type is not checked because it is not an expected input.
Updated the compute distance function to use row_norms.
ENH Added error bars to scalability example plots.
trees_ and original_indices_ are public members of LSHForest.
Fixed incompatible dtypes.
Member
|
"what's new"? |
Member
Author
|
Good point. c6b2049. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#3894 in just over 80 commits. Moved some LSH-specific utility code back out of the neighbors base classes.
I just want to see if the tests work on this one.