Skip to content

DOC Clean up Building from source instructions on macOS#31938

Merged
lesteve merged 2 commits intoscikit-learn:mainfrom
DeaMariaLeon:env-doc
Aug 13, 2025
Merged

DOC Clean up Building from source instructions on macOS#31938
lesteve merged 2 commits intoscikit-learn:mainfrom
DeaMariaLeon:env-doc

Conversation

@DeaMariaLeon
Copy link
Copy Markdown
Member

@DeaMariaLeon DeaMariaLeon commented Aug 13, 2025

Reference Issues/PRs

Closes #29603, closes #29603, closes #31359, closes #31361
Closes #31930

What does this implement/fix? Explain your changes.

The environment variables removed with this PR are not needed. That's because "meson will automatically find the compiler with the right OpenMP flags."

Friendly ping @lesteve.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Aug 13, 2025

✔️ Linting Passed

All linting checks passed. Your pull request is in excellent shape! ☀️

Generated for commit: 5f45940. Link to the linter CI: here

Copy link
Copy Markdown
Member

@lesteve lesteve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, let's merge this one!

@lesteve lesteve merged commit e402663 into scikit-learn:main Aug 13, 2025
36 checks passed
@DeaMariaLeon DeaMariaLeon deleted the env-doc branch August 13, 2025 10:18
lucyleeow pushed a commit to lucyleeow/scikit-learn that referenced this pull request Aug 22, 2025
jeremiedbb pushed a commit to jeremiedbb/scikit-learn that referenced this pull request Sep 3, 2025
@jeremiedbb jeremiedbb mentioned this pull request Sep 3, 2025
13 tasks
DeaMariaLeon added a commit to DeaMariaLeon/scikit-learn that referenced this pull request Sep 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

2 participants