DOC: Add missing link to example in plot_digits_agglomeration.py#31681
DOC: Add missing link to example in plot_digits_agglomeration.py#31681Nachi28 wants to merge 4 commits intoscikit-learn:mainfrom
Conversation
virchan
left a comment
There was a problem hiding this comment.
Thanks for the PR and continuing the work from #30979, @Nachi28! I have a few comments.
- In the "Reference Issues/PRs" section of the PR description, could you please replace "
Fixes #30979" with "Towards #26927"? This helps us better track progress on the meta issue. - I also think it would be helpful to include the example link in the docstring for
FeatureAgglomeration.
Cc @StefanieSenger in advance.
I have updated both the things please verify |
| .. rubric:: Examples | ||
|
|
||
| * :ref:`sphx_glr_auto_examples_cluster_plot_digits_agglomeration.py`: This | ||
| example shows how similar features are merged together using feature | ||
| agglomeration. | ||
|
|
There was a problem hiding this comment.
The example link seems a little unnecessary here.
There was a problem hiding this comment.
I think the example link fits better under Unsupervised Dimensionality Reduction, where it's already included. Could you please remove it from here?
|
I am going to close this due to inactivity and because we have decided to close #30621. |
|
Re-opening, as this was reviewed and someone else may wish to continue |
|
Closing since the OP hasn't applied reviews in a while. |
Reference Issues/PRs
Towards #30979
Supersedes and continues work from PR #30979 by @AshleyNDoerfler
What does this implement/fix? Explain your changes.
This PR adds the missing reference link to the example
plot_digits_agglomeration.pyin the clustering user guide (clustering.rst), specifically under the Feature Agglomeration section.Additionally:
Any other comments?
Please let me know if there are any additional changes or improvements you'd like me to make.