DOC: add link to example plot_digits_agglomeration.py#30979
DOC: add link to example plot_digits_agglomeration.py#30979AshleyNDoerfler wants to merge 3 commits intoscikit-learn:mainfrom
Conversation
doc/modules/clustering.rst
Outdated
|
|
||
| * :ref:`sphx_glr_auto_examples_cluster_plot_digits_agglomeration.py`: This | ||
| example shows how similar features are merged together using feature | ||
| agglomeration |
There was a problem hiding this comment.
| agglomeration | |
| agglomeration. | |
I think this shall fix the linting issue.
StefanieSenger
left a comment
There was a problem hiding this comment.
Hi @AshleyNDoerfler, thanks for your PR.
We need to fix the linting issues.
|
Hi @StefanieSenger, I added the period and committed it. I believe it should be good to go. |
|
|
||
| * :ref:`sphx_glr_auto_examples_cluster_plot_digits_agglomeration.py`: This | ||
| example shows how similar features are merged together using feature | ||
| agglomeration. |
There was a problem hiding this comment.
| agglomeration. | |
| agglomeration. | |
You also need to add an empty line.
There was a problem hiding this comment.
Hi Stefanie, I am trying the add the empty line, but it fails "Trim trailing white spaces" when I try to commit the change. Do you know what's causing this issue?
There was a problem hiding this comment.
That's pre-commit in action. Please google how pre-commit works: you need to add the changed files and commit again.
There was a problem hiding this comment.
Or you can commit my suggestion in the changed files part of this PR.
|
Hi @AshleyNDoerfler, |
|
I am going to close this due to inactivity and because we have decided to close #30621. |
Reference Issues/PRs
What does this implement/fix? Explain your changes.
An example for plot_digits_agglomeration.py was missing in the clustering documentation, so I added it into clustering.rst under the feature agglomeration section.
Any other comments?