DOC Removed examples/semi_supervised/plot_semi_supervised_versus_svm_iris.py#31625
DOC Removed examples/semi_supervised/plot_semi_supervised_versus_svm_iris.py#31625elhambbi wants to merge 1 commit intoscikit-learn:mainfrom
Conversation
|
Hi @StefanieSenger. I created this PR to remove the example mentioned in #31499 (this example is not referenced anywhere). |
There was a problem hiding this comment.
Hi @elhambbi, thanks for this PR to remove the example as we had discussed with @adrinjalali.
There are a few tasks that are left to be done:
- Remove the references to this example in
doc/modules/semi_supervised.rst(in currently li. 66 and in li. 139) - We need to add a redirection in
doc/conf.pyto the re-worked example in case the removed example had been linked externally. You can use #30906 as a guide of how to do that. - Could you shortly sum up, what are the interesting things from the deleted example, that you would like to integrate into your re-worked example in #31104? Are there any at all?
No worries about the failing CI checks, btw, they come from main and have nothing to do with your PR.
|
This PR is a follow up to #31104 which is now merged. The decision to use the @ArturoAmorQ, do you agree? I wasn't sure, since @elhambbi wrote you might have suggested something else (here), but I didn't find where you did it. @elhambbi, there are a few things left to be done before we can merge this PR. Please have a look at the link in the comment above as an example of how to remove an example and add a redirection. |
|
Oh, now I have found #32024, which improves the Then let's close this PR? |
|
We've discussed that we want to keep the example and @ArturoAmorQ has opened a PR #32024 to improve it. Therefore, I am closing this PR. |
Reference Issues/PRs
Removed the example
examples/semi_supervised/plot_semi_supervised_versus_svm_iris.pyas discussed in #31499What does this implement/fix? Explain your changes.
The performance of semi-supervised methods, SelfTraining and LabelSpreading, is already evaluated in this example, which is improved in #31104. There is no need for more examples to show this.
Any other comments?