Removed plot_sgd_comparison.py example#30906
Merged
adrinjalali merged 1 commit intoscikit-learn:mainfrom Mar 18, 2025
Merged
Conversation
adrinjalali
approved these changes
Mar 18, 2025
Contributor
Author
|
@adrinjalali thank you! this is my first contribution! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
What does this implement/fix? Explain your changes.
Removed plot_sgd_comparison.py example and added redirection to plot_sgd_loss_functions.py
Any other comments?
After discussing with Adrin: The example is not documented well, it uses outdated solvers (PassiveAgressive is meant to be removed), it claims to demonstrate online solvers, but isn't using any mini-batching/ data streaming.