Skip to content

DOC Add vector quantization example to KBinsDiscretizer docs#31613

Merged
adrinjalali merged 7 commits intoscikit-learn:mainfrom
pw42020:main
Aug 5, 2025
Merged

DOC Add vector quantization example to KBinsDiscretizer docs#31613
adrinjalali merged 7 commits intoscikit-learn:mainfrom
pw42020:main

Conversation

@pw42020
Copy link
Copy Markdown
Contributor

@pw42020 pw42020 commented Jun 20, 2025

Add vector quantization example to KBinsDiscretizer docs

Reference Issues/PRs

#30621 regarding examples/cluster/plot_face_compress.py

What does this implement/fix? Explain your changes.

Adds additional documentation to the KBinsDiscretizer document in the form of an important note that it only outputs floats. This is shown to be an important use case in the Vector Quantization example where the size of the image is increased by 8x due to the transition from int8 (0-255) to float64.

Any other comments?

No.

pw42020 added 4 commits June 20, 2025 15:09
…drastically increase in size using this algorithm, shown by the example plot_face_Compress
@github-actions
Copy link
Copy Markdown

github-actions bot commented Jun 20, 2025

✔️ Linting Passed

All linting checks passed. Your pull request is in excellent shape! ☀️

Generated for commit: 29db284. Link to the linter CI: here

Copy link
Copy Markdown
Member

@StefanieSenger StefanieSenger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's a valuable addition, thanks a lot @pw42020!
I only have a little suggestion to improve wording.

Co-authored-by: Stefanie Senger <91849487+StefanieSenger@users.noreply.github.com>
Copy link
Copy Markdown
Member

@StefanieSenger StefanieSenger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @pw42020. That looks very good. 😄

Would you like to have a look as well, @adrinjalali?

Copy link
Copy Markdown

@Abhijais4896 Abhijais4896 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed

@adrinjalali
Copy link
Copy Markdown
Member

@pw42020 thanks for the PR. Please make sure in the future not to apply your changes to your main branch, and rather have a separate branch for each contribution.

@adrinjalali adrinjalali changed the title Add vector quantization example to KBinsDiscretizer docs DOC Add vector quantization example to KBinsDiscretizer docs Aug 5, 2025
@adrinjalali adrinjalali merged commit adb1ae7 into scikit-learn:main Aug 5, 2025
37 checks passed
lucyleeow pushed a commit to lucyleeow/scikit-learn that referenced this pull request Aug 22, 2025
…learn#31613)

Co-authored-by: Stefanie Senger <91849487+StefanieSenger@users.noreply.github.com>
@jeremiedbb jeremiedbb mentioned this pull request Sep 3, 2025
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants