BLD: use more modern way to specify license metadata#31560
BLD: use more modern way to specify license metadata#31560adrinjalali merged 2 commits intoscikit-learn:mainfrom
Conversation
|
Looking at the failing CI test, I see at https://dev.azure.com/scikit-learn/scikit-learn/_build/results?buildId=77349&view=logs&jobId=85dc54f1-b746-54c6-aaa8-29d3ad6201c9&j=85dc54f1-b746-54c6-aaa8-29d3ad6201c9&t=5f5d7705-2bc0-5dba-fcc6-e1cf6a70293a but here https://scikit-learn.org/stable/install.html it says that 1.7 requires Python 3.10 or later not sure if this is related to my CI issue though... |
|
I think the python version reported in the step that you linked to is a red herring. In our CI we always (I think) setup a conda environment in which all the work is done. So the python version shown in the CI step is more like the "system Python", not what is actually used. For example for this job the conda environment is based on https://github.com/scikit-learn/scikit-learn/blob/main/build_tools/azure/pymin_conda_forge_openblas_min_dependencies_environment.yml which specifies python 3.10 I wonder if the explanation for why this job fails and the others dont is the version of meson-python (0.16 for the minimum deps job, 0.18 in If we can confirm it is due to meson-python, I would then summon @lesteve to see if we can bump the version up or not. |
|
@betatim I've tried locally with different For Show-versions output: |
|
Let's go ahead and bump up the minimum version in scikit-learn/sklearn/_min_dependencies.py Line 27 in 031d2f8 After updating the minimum version in that file you'll have to regenerate the lockfiles with |
|
This looks like this PR broke the wheel build, see #31590 (comment) for more details. |
Oh no, sorry about that! I assumed it would be okay because the CI was passing |
Reference Issues/PRs
Closes #30766
What does this implement/fix? Explain your changes.
Updates means of specifying LICENSE. See https://packaging.python.org/en/latest/guides/writing-pyproject-toml/#license-and-license-files
Any other comments?
N/A
@betatim @glemaitre