DOC add link to plot_cv_predict example in cross_val_predict doc#31504
Merged
adrinjalali merged 13 commits intoscikit-learn:mainfrom Jun 18, 2025
sisird864:docs/link-plot_cv_predict
Merged
DOC add link to plot_cv_predict example in cross_val_predict doc#31504adrinjalali merged 13 commits intoscikit-learn:mainfrom sisird864:docs/link-plot_cv_predict
adrinjalali merged 13 commits intoscikit-learn:mainfrom
sisird864:docs/link-plot_cv_predict
Conversation
virchan
reviewed
Jun 9, 2025
Member
virchan
left a comment
There was a problem hiding this comment.
Thank you for the PR, @sisird864! I have a few comments.
- The hash symbols can be removed.
- Please add a blank line between the descriptive text and the Python code.
- "For a detailed example of using
cross_val_predictto visualize prediction errors, please see <example_link>."
virchan
reviewed
Jun 13, 2025
Member
virchan
left a comment
There was a problem hiding this comment.
Thanks for the update, @sisird864! I have a few more comments.
The example you added has split the Python code block in the Examples section in half, which breaks the formatting. Could you please move the text outside the code block?
…864/scikit-learn into docs/link-plot_cv_predict
virchan
reviewed
Jun 13, 2025
Member
virchan
left a comment
There was a problem hiding this comment.
Thank you for updating the PR, @sisird864! I have a few more comments.
Comment on lines
+1166
to
+1168
| For a detailed example of using ``cross_val_predict`` to visualize | ||
| prediction errors, please see | ||
| :ref:`this example <sphx_glr_auto_examples_model_selection_plot_cv_predict.py>`. |
Member
There was a problem hiding this comment.
We don't need "this example" inside :ref: here.
virchan
reviewed
Jun 16, 2025
Member
virchan
left a comment
There was a problem hiding this comment.
Thanks you for updating the PR, @sisird864! Just one more nitpick.
Co-authored-by: Virgil Chan <virchan.math@gmail.com>
virchan
approved these changes
Jun 17, 2025
Member
virchan
left a comment
There was a problem hiding this comment.
LGTM! Thanks @sisird864!
@adrinjalali, @marenwestermann, would you like to have a look and merge this?
adrinjalali
approved these changes
Jun 18, 2025
jeremiedbb
pushed a commit
to jeremiedbb/scikit-learn
that referenced
this pull request
Jul 15, 2025
…kit-learn#31504) Co-authored-by: Virgil Chan <virchan.math@gmail.com>
jeremiedbb
pushed a commit
to jeremiedbb/scikit-learn
that referenced
this pull request
Jul 16, 2025
…kit-learn#31504) Co-authored-by: Virgil Chan <virchan.math@gmail.com>
jeremiedbb
pushed a commit
to jeremiedbb/scikit-learn
that referenced
this pull request
Jul 16, 2025
…kit-learn#31504) Co-authored-by: Virgil Chan <virchan.math@gmail.com>
jeremiedbb
pushed a commit
to jeremiedbb/scikit-learn
that referenced
this pull request
Jul 16, 2025
…kit-learn#31504) Co-authored-by: Virgil Chan <virchan.math@gmail.com>
jeremiedbb
pushed a commit
to jeremiedbb/scikit-learn
that referenced
this pull request
Jul 16, 2025
…kit-learn#31504) Co-authored-by: Virgil Chan <virchan.math@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Towards #30621
What does this implement/fix? Explain your changes.
This adds a new entry under the “See Also” section of the
cross_val_predictAPI docstring insklearn/model_selection/_validation.py, linking to theplot_cv_predict.pyexample: