DOC Add link to plot_gmm_pdf.py in GaussianMixture examples#31230
DOC Add link to plot_gmm_pdf.py in GaussianMixture examples#31230marenwestermann merged 6 commits intoscikit-learn:mainfrom
Conversation
StefanieSenger
left a comment
There was a problem hiding this comment.
thank you for your contribution. I would suggest a change in phrasing, to express what is special about this example compared to other examples on GaussianMixture.
Maybe move the link inside the docstring of the score_samples method in sklearn/mixture/_base.py, which is displayed both in GaussianMixture as well as in BaysianGaussianMixture, though it might be worth it. What do you think?
sklearn/mixture/_gaussian_mixture.py
Outdated
| Gaussian Mixture Models are commonly used for probability density estimation and | ||
| modeling multi-modal distributions. For a visualization, see | ||
| :ref:`sphx_glr_auto_examples_mixture_plot_gmm_pdf.py` |
There was a problem hiding this comment.
I would suggest to directly describe what the example shows. Maybe like this:
| Gaussian Mixture Models are commonly used for probability density estimation and | |
| modeling multi-modal distributions. For a visualization, see | |
| :ref:`sphx_glr_auto_examples_mixture_plot_gmm_pdf.py` | |
| For an illustration of the negative log-likelihood surface of a | |
| :class:`~sklearn.mixture.GaussianMixture` Model, | |
| see :ref:`sphx_glr_auto_examples_mixture_plot_gmm_pdf.py`. |
|
Hi @vivaannanavati123, are you still interested in working on that? |
|
I am going to close this due to inactivity and because we have decided to close the issue #30621. |
|
Re-opening, as this was reviewed and someone else may wish to continue |
marenwestermann
left a comment
There was a problem hiding this comment.
This PR should have been closed straight away as it very much looks AI generated. However, I didn't want @StefanieSenger's work go to waste. I will merge when the CI is green.
Co-authored-by: Vivaan Nanavati <vivaan@Vivaans-MacBook-Pro.local> Co-authored-by: Maren Westermann <maren.westermann@gmail.com>
Reference Issues/PRs
Addresses #30621.
What does this implement/fix? Explain your changes.
plot_gmm_pdf.pyinGaussianMixturedocstring examples to demonstrate density estimation, a key GMM use case missing in API docs.plot_gmm_pdf.pyin API docs.Any other comments?
Noticed that
plot_roc_crossval.pyis already linked in User Guide sections (model_evaluation.rst,cross_validation.rst) and related examples, so I would recommend for it to be checked off.Thank you for your review!