Skip to content

MAINT XFAIL check_sample_weight_equivalence for LinearRegression on 32 bit CI#31101

Merged
ogrisel merged 1 commit intoscikit-learn:mainfrom
ogrisel:xfail-check_sample_weight_equivalence_on_dense_data-LinearRegression-32bit-linux
Mar 28, 2025
Merged

MAINT XFAIL check_sample_weight_equivalence for LinearRegression on 32 bit CI#31101
ogrisel merged 1 commit intoscikit-learn:mainfrom
ogrisel:xfail-check_sample_weight_equivalence_on_dense_data-LinearRegression-32bit-linux

Conversation

@ogrisel
Copy link
Copy Markdown
Member

@ogrisel ogrisel commented Mar 28, 2025

Temporary workaround for #31098.

To be removed once the problem has been reported and fixed upstream.

@github-actions
Copy link
Copy Markdown

✔️ Linting Passed

All linting checks passed. Your pull request is in excellent shape! ☀️

Generated for commit: 1ea47c0. Link to the linter CI: here

@ogrisel
Copy link
Copy Markdown
Member Author

ogrisel commented Mar 28, 2025

If CI goes through, I think this should be merged asap to unred all CIs in all PRs. Let me mark as automerge.

@ogrisel ogrisel enabled auto-merge (squash) March 28, 2025 16:17
@jeremiedbb
Copy link
Copy Markdown
Member

you still need an approved review otherwise merging is block even if you set auto-merge :)

Copy link
Copy Markdown
Member

@jeremiedbb jeremiedbb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. It would helpful to link to the upstream issue when it's opened

@ogrisel ogrisel merged commit 4f847f5 into scikit-learn:main Mar 28, 2025
40 checks passed
@ogrisel ogrisel deleted the xfail-check_sample_weight_equivalence_on_dense_data-LinearRegression-32bit-linux branch March 31, 2025 05:09
lucyleeow pushed a commit to lucyleeow/scikit-learn that referenced this pull request Apr 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants