DOC add link to plot_confusion_matrix example in confusion_matrix.py#30949
Conversation
virchan
left a comment
There was a problem hiding this comment.
Thank you for the PR, @Nujra40!
I have a few comments.
360bc67 to
1b7c8af
Compare
1b7c8af to
87120c5
Compare
|
Hi @virchan I have made the changes, Can I get a review |
virchan
left a comment
There was a problem hiding this comment.
LGTM! Thanks @Nujra40!
@adrinjalali, @marenwestermann, would you like to have a look and merge this?
87120c5 to
88facc2
Compare
marenwestermann
left a comment
There was a problem hiding this comment.
The function confusion_matrix where the example is currently linked according to this PR is actually not used in the example. The method which is used is `ConfusionMatrixDisplay.from_estimator. So the example needs to be linked there.
…t/confusion_matrix.py
88facc2 to
0e4347a
Compare
|
Hi @marenwestermann I have made the requested changes. Are there any further changes required? |
marenwestermann
left a comment
There was a problem hiding this comment.
Thank you for your contribution @Nujra40. Looks good to me, I just added a blank line above your documentation and merged the latest changes from the main branch into your branch. Note for the future that force pushing shouldn't be required, a normal git push is sufficient.
…cikit-learn#30949) Co-authored-by: Maren Westermann <maren.westermann@gmail.com>
[DOC] Add link to plot_confusion_matrix example in sklearn/metrics/_plot/confusion_matrix.py
This PR adds a reference link to the plot_confusion_matrix example in sklearn/metrics/_plot/confusion_matrix.py for better documentation accessibility.
Changes:
Testing:
Towards #30621.