DOC Add links to example plot_image_denoising.py#30864
DOC Add links to example plot_image_denoising.py#30864marenwestermann merged 7 commits intoscikit-learn:mainfrom
Conversation
StefanieSenger
left a comment
There was a problem hiding this comment.
Thanks a lot, @GesaLoof!
The example is already linked several times in the section above ("Generic dictionary learning"), but it uses MiniBatchDictionaryLearning and thus would rather belong to the section you have linked it to. Since we don't want to pollute the UserGuide too much and aim to pin point examples to their best spots: would you suggest to actually remove a few of the references above, for instance this one or maybe more? What do you think?
Co-authored-by: Stefanie Senger <91849487+StefanieSenger@users.noreply.github.com>
Co-authored-by: Stefanie Senger <91849487+StefanieSenger@users.noreply.github.com>
|
Hello @GesaLoof, thanks for the changes. The example-linking looks good now. Only one more thing: you have changed and pushed the Thanks a lot! |
|
Hi @StefanieSenger |
StefanieSenger
left a comment
There was a problem hiding this comment.
Yes, I remember. I am glad you found a solution!
So, this PR looks fine! Thank you for your work!
Can we merge it, @marenwestermann or @adrinjalali ?
|
Amazing, thank you so much for helping and teaching us how to contribute! |
adrinjalali
left a comment
There was a problem hiding this comment.
I think this also reserves to have a link in the MiniBatchDictionaryLearning docstring.
|
Hi @GesaLoof! Would you like to continue working on this pull request? |
|
I finished the PR. Thank you for your contribution @GesaLoof! |
Co-authored-by: Stefanie Senger <91849487+StefanieSenger@users.noreply.github.com> Co-authored-by: Maren Westermann <maren.westermann@gmail.com>
Reference Issues/PRs
Towards Issue #30621 - Linked example plot_image_denoising.py for Mini-batch dictionary learning
What does this implement/fix? Explain your changes.
Added example plot_image_denoising.py for Mini-batch dictionary learning in the User Guide section 2.5.4.3.
Nothing changed in API documentation.
Any other comments?
@adrinjalali
@StefanieSenger