Skip to content

DOC Add link to plot_lasso_and_elasticnet.py example in linear model #30587

Closed
marouaneaka wants to merge 12 commits intoscikit-learn:mainfrom
marouaneaka:update-docs
Closed

DOC Add link to plot_lasso_and_elasticnet.py example in linear model #30587
marouaneaka wants to merge 12 commits intoscikit-learn:mainfrom
marouaneaka:update-docs

Conversation

@marouaneaka
Copy link
Copy Markdown

@marouaneaka marouaneaka commented Jan 5, 2025

Reference Issues/PRs

What does this implement/fix? Explain your changes.

Towards 26927
Added links to lasso and elasticnet classes

Any other comments?

@github-actions
Copy link
Copy Markdown

github-actions bot commented Jan 5, 2025

✔️ Linting Passed

All linting checks passed. Your pull request is in excellent shape! ☀️

Generated for commit: 645bd17. Link to the linter CI: here

Copy link
Copy Markdown
Member

@virchan virchan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR @marouaneaka! I have a few comments:

  1. It might be helpful to include a link to the example in the ARD regression documentation as well.
  2. In the PR description, please update the text to "Towards 26927" to avoid automatically closing the meta-issue when the PR is merged.

>>> print(regr.predict([[0, 0]]))
[1.451...]

For an example showcasing Elastic-Net alongside Lasso and ARDRegression for sparse
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"ARD regression", and likewise for Lasso.

@marouaneaka
Copy link
Copy Markdown
Author

Hi thanks for the comments : - Added link in ARD Regression, fixed typo mistake in elastic net and lasso. if there is anything else just let me know :)

Copy link
Copy Markdown
Member

@virchan virchan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for updating the PR, @marouaneaka! I have a few more comments.

In the ARD Regression documentation, could you please move the following example:

Screenshot 2025-01-10 142444

down to where your L1 example is? After that, you can delete the "Notes" section.

@marouaneaka
Copy link
Copy Markdown
Author

Just updated ARD documentation as specified

Copy link
Copy Markdown
Member

@virchan virchan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for updating the PR, @marouaneaka! Could you address the CI failure? If you click on "Details" under "scikit-learn.scikit-learn," you’ll find the error message(s).

@marenwestermann
Copy link
Copy Markdown
Member

Hi @marouaneaka! Would you like to continue working on this PR? Let us know if you need help.

supersom added a commit to supersom/scikit-learn that referenced this pull request May 26, 2025
…ARD docstrings and demonstrating ARD to ARD docstring [as in PR scikit-learn#30587]
@StefanieSenger StefanieSenger added the Superseded PR has been replace by a newer PR label May 27, 2025
@StefanieSenger
Copy link
Copy Markdown
Member

This PR had been superseded by #31425 and can now be closed, since the superseding PR got merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants