Skip to content

CI Bump macOS version to 13 on Azure#30169

Closed
lesteve wants to merge 1 commit intoscikit-learn:mainfrom
lesteve:azure-macos-12-deprecation
Closed

CI Bump macOS version to 13 on Azure#30169
lesteve wants to merge 1 commit intoscikit-learn:mainfrom
lesteve:azure-macos-12-deprecation

Conversation

@lesteve
Copy link
Copy Markdown
Member

@lesteve lesteve commented Oct 28, 2024

See actions/runner-images#10721. macOS-12 removal on Azure is scheduled for December 2024, brownout windows will start in November 2024.

@lesteve lesteve added the Quick Review For PRs that are quick to review label Oct 28, 2024
@github-actions
Copy link
Copy Markdown

✔️ Linting Passed

All linting checks passed. Your pull request is in excellent shape! ☀️

Generated for commit: fcece4a. Link to the linter CI: here

Copy link
Copy Markdown
Member

@ogrisel ogrisel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if it goes through.

@ogrisel ogrisel enabled auto-merge (squash) October 28, 2024 11:07
@ogrisel
Copy link
Copy Markdown
Member

ogrisel commented Oct 28, 2024

Maybe we can try to merge this to see if this has any impact on the stalled jobs?

It's easy to revert in case we need to.

@lesteve
Copy link
Copy Markdown
Member Author

lesteve commented Oct 28, 2024

Looks like Azure CI jobs are running again at least in this PR 🎉 but not #30167 apparently 😅.

For completeness, conda-forge has seen the same issue of Azure CI not being triggered conda-forge/status#188 and there is now an acknowledged Azure Devops incident https://status.dev.azure.com/_event/559260722. So hopefully this should be fixed for real in the not so distant future.

@lesteve
Copy link
Copy Markdown
Member Author

lesteve commented Oct 28, 2024

Ah after reading your Discord message, I guessed you did manually trigger the Azure build

@ogrisel
Copy link
Copy Markdown
Member

ogrisel commented Oct 28, 2024

Yes I did sorry...

@ogrisel
Copy link
Copy Markdown
Member

ogrisel commented Oct 28, 2024

The CONDA environment variable is no longer there on macOS-13 apparently. We might need to install conda with miniforge instead?

@glemaitre
Copy link
Copy Markdown
Member

I'm reading this thread that is related: actions/runner-images#9262

@glemaitre
Copy link
Copy Markdown
Member

So indeed, it seems that the way to go is to install miniconda manually on the MacOS runner.

@glemaitre glemaitre self-requested a review October 31, 2024 09:21
@glemaitre
Copy link
Copy Markdown
Member

glemaitre commented Oct 31, 2024

A subsequent question now is about the type of CPU on those machines? On GitHub action macos-12 was the latest runner for Intel CPU. So I'm wondering here what is the CPUs with the macos-13.

We can easily make the script adaptable to download the right archive though.

@glemaitre
Copy link
Copy Markdown
Member

glemaitre commented Oct 31, 2024

I open the following PR against this branch: lesteve#39

I open this PR to see if it works and apparently, it worked almost :): #30185

While the install of miniforge is fine, it seems that there something wrong in the subsequent install with OpenMP (apparently the uninstalling of OpenMP for one of the build). I'll add the --force flag to ignore the error but it would mean that openmp is not anymore installed on the runner-image as well?

@lesteve
Copy link
Copy Markdown
Member Author

lesteve commented Oct 31, 2024

Closing in favour of #30185

@lesteve lesteve closed this Oct 31, 2024
auto-merge was automatically disabled October 31, 2024 16:51

Pull request was closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Build / CI Quick Review For PRs that are quick to review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants