Skip to content

CI Bump macOS version to 13 on Azure#30185

Merged
jeremiedbb merged 29 commits intoscikit-learn:mainfrom
glemaitre:try_install_miniforge
Nov 4, 2024
Merged

CI Bump macOS version to 13 on Azure#30185
jeremiedbb merged 29 commits intoscikit-learn:mainfrom
glemaitre:try_install_miniforge

Conversation

@glemaitre
Copy link
Copy Markdown
Member

@glemaitre glemaitre commented Oct 31, 2024

See actions/runner-images#10721. macOS-12 removal on Azure is scheduled for December 2024, brownout windows will start in November 2024.

@glemaitre glemaitre marked this pull request as draft October 31, 2024 09:43
@github-actions
Copy link
Copy Markdown

github-actions bot commented Oct 31, 2024

✔️ Linting Passed

All linting checks passed. Your pull request is in excellent shape! ☀️

Generated for commit: 0ec617d. Link to the linter CI: here

Co-authored-by: Loïc Estève <loic.esteve@ymail.com>
echo "##vso[task.prependpath]$CONDA/bin"

# Take ownership of conda installation
sudo chown -R $USER $CONDA
Copy link
Copy Markdown
Member

@lesteve lesteve Oct 31, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need this only when conda is installed so maybe put it in a else clause of if [[ -z "${CONDA}" ]]?

IIRC CONDA is a system folder which somehow causes issue somewhere ...

@glemaitre glemaitre force-pushed the try_install_miniforge branch from 7ee870c to 53dbe9f Compare October 31, 2024 14:13
@glemaitre glemaitre marked this pull request as ready for review October 31, 2024 14:23
@lesteve lesteve changed the title [DEBUG] try to install miniforge on MacOS runner in Azure pipeline CI Bump macOS version to 13 on Azure Oct 31, 2024
@lesteve
Copy link
Copy Markdown
Member

lesteve commented Oct 31, 2024

I pushed some simplification for the script which hopefully should not break things too much 🤞

@glemaitre
Copy link
Copy Markdown
Member Author

Nice @lesteve

Copy link
Copy Markdown
Member

@lesteve lesteve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for keeping at it until it worked!

Copy link
Copy Markdown
Member

@jeremiedbb jeremiedbb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jeremiedbb jeremiedbb merged commit 44017bb into scikit-learn:main Nov 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants