[MRG+2] MAINT warn of future behaviour change proposed in #2610#2952
Merged
jnothman merged 1 commit intoscikit-learn:masterfrom Apr 7, 2014
Merged
[MRG+2] MAINT warn of future behaviour change proposed in #2610#2952jnothman merged 1 commit intoscikit-learn:masterfrom
jnothman merged 1 commit intoscikit-learn:masterfrom
Conversation
Member
|
sklearn/linear_model/cd_fast.c is modified in this PR |
Member
Author
It was removed immediately after posting. |
Member
|
+1 on my side. |
Member
|
Looks good +1 |
Member
Author
|
I guess this should be merged, and then the real changes come after the release. |
jnothman
added a commit
that referenced
this pull request
Apr 7, 2014
MAINT warn of future behaviour change proposed in #2610
This was referenced Apr 30, 2014
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Assuming my proposal in #2610 to make PRF's
labelsparameter more functional and deprecatepos_labelgoes through at some future point, it will create a compatibility issue in the case where all of the following apply:y_trueandy_predcontain at most two labelslabelsspecifies exactly two labelspos_labelis not None (default)averageis not None (generally default).I expect this case is rare atm, but since behaviour would change with #2610 or similar (unless
labelschanged its name), we can warn in this release (0.15) and change behaviour in 0.16 or 0.17.