Skip to content

DOC add link for NearestCentroid example#28984

Merged
adrinjalali merged 3 commits intoscikit-learn:mainfrom
J-Enblom:doc_plot_nearest_centroid
Jun 10, 2024
Merged

DOC add link for NearestCentroid example#28984
adrinjalali merged 3 commits intoscikit-learn:mainfrom
J-Enblom:doc_plot_nearest_centroid

Conversation

@J-Enblom
Copy link
Copy Markdown
Contributor

@J-Enblom J-Enblom commented May 9, 2024

Reference Issues/PRs

#26927

What does this implement/fix? Explain your changes.

This PR adds a link to plot_nearest_centroid.py in _nearest_centroid.py for the NearestCentroid class.

@github-actions
Copy link
Copy Markdown

github-actions bot commented May 9, 2024

✔️ Linting Passed

All linting checks passed. Your pull request is in excellent shape! ☀️

Generated for commit: 8e5ea8e. Link to the linter CI: here

Copy link
Copy Markdown
Member

@adrinjalali adrinjalali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR.

Comment on lines +32 to +33
For sample usage of NearestCentroid, refer to
:ref:`sphx_glr_auto_examples_neighbors_plot_nearest_centroid.py`
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
For sample usage of NearestCentroid, refer to
:ref:`sphx_glr_auto_examples_neighbors_plot_nearest_centroid.py`
For a more detailed example see:
:ref:`sphx_glr_auto_examples_neighbors_plot_nearest_centroid.py`

also needs to be moved to the Examples section bellow.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the review, hoping it looks better now!

@adrinjalali adrinjalali merged commit 30cf4a0 into scikit-learn:main Jun 10, 2024
jeremiedbb pushed a commit to jeremiedbb/scikit-learn that referenced this pull request Jul 2, 2024
@jeremiedbb jeremiedbb mentioned this pull request Jul 2, 2024
11 tasks
jeremiedbb pushed a commit to jeremiedbb/scikit-learn that referenced this pull request Jul 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants