Merged
Conversation
Member
|
#22046 seems like a blocker |
Contributor
Author
|
@lorentzenchr @ogrisel I updated this PR |
ogrisel
reviewed
Jul 1, 2025
Member
ogrisel
left a comment
There was a problem hiding this comment.
Thanks for the PR. Here is a first pass of feedback.
Note: once this PR is merged, feel free to follow-up with a PR to add array API support.
lorentzenchr
approved these changes
Jul 17, 2025
doc/whats_new/upcoming_changes/sklearn.metrics/28971.feature.rst
Outdated
Show resolved
Hide resolved
ogrisel
approved these changes
Jul 31, 2025
Member
ogrisel
left a comment
There was a problem hiding this comment.
LGTM, thank you very much @OmarManzoor!
Member
|
GitHub auto-merged with a blue tick without actually re-running the full test suite... Hopefully that won't break |
Contributor
Author
|
Thank you for the reviews @lorentzenchr and @ogrisel |
lucyleeow
pushed a commit
to lucyleeow/scikit-learn
that referenced
this pull request
Aug 22, 2025
Co-authored-by: Olivier Grisel <olivier.grisel@ensta.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Closes #20943
What does this implement/fix? Explain your changes.
Any other comments?
CC: @lorentzenchr