MAINT cleanup utils.__init__: move IS_PYPY, _IS_WASM, _IS_32BIT into utils.fixes#28768
Merged
ogrisel merged 3 commits intoscikit-learn:mainfrom Apr 8, 2024
Merged
MAINT cleanup utils.__init__: move IS_PYPY, _IS_WASM, _IS_32BIT into utils.fixes#28768ogrisel merged 3 commits intoscikit-learn:mainfrom
ogrisel merged 3 commits intoscikit-learn:mainfrom
Conversation
lorentzenchr
approved these changes
Apr 4, 2024
ogrisel
approved these changes
Apr 8, 2024
ogrisel
reviewed
Apr 8, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extracted from #26686 to ease the reviews. The end goal is to clean the
utils.__init__module as explained in the linked PR.The closest module I found for compat stuff like this is
utils.fixes, but open to better suggestions.I checked around and it looks like
IS_PYPYis used at least byimbalanced-learn, so I kindly deprecated it (although it was never meant to be public @glemaitre 😄 ). I also renamed it_IS_PYPY, with a leading underscore to make it explicitly private.I didn't find any external usage of
_IS_WASMand_IS_32BIT, so I think it's safe to move them without further notice.