Even if the diff is big, it's just moving stuff around. I did not modify a single line of actual code 😄

✔️ Linting Passed

All linting checks passed. Your pull request is in excellent shape! ☀️

_{Generated for commit: 0949a9c. Link to the linter CI: here}

This looks like a good thing to do and the structure/grouping is probably as good as it can be given that the starting point was this mixed bag of random stuff.

One question: should we keep exposing things that used to be in sklearn.utils in that place? Basically the question is if those functions are part of the public API and how we deal with deprecation related to moving the functions to a new namespace.

One question: should we keep exposing things that used to be in sklearn.utils in that place?

• For public functions (i.e. listed in classes.rst), I still left them exposed in utils
• For almost all private functions, I stopped exposing them in utils and modified the imports in the rest of the code base to import them from their submodule.
• Except for the functions in utils._misc that I left exposed in utils because it felt wrong to import them from _misc since misc is not informative and is something I'd like to get rid of at some point.

Ah, looks like I could have figured that out from actually reading the diff ... I skipped it because it was so big :-/

Hi @jeremiedbb, is there something blocking this PR or is it ready to be reviewed?

It would need to be sync with main. I am +1 with the spirit of this PR.
I think that once sync we should be quick at merging.

If the function starting with _ are still importable from the top module, then we are not going to break third-library codes that would use those semi-public (developer) functions.

Since we always advocate to have a third-party developer section, I think this need to be done before to go in the documentation where can list which tools are actually useful for third-party libraries.

Everything has been moved outside of utils.__init__ in individual PRs. We can close this one.