Skip to content

REVERT DOC Fix typo - a better typo#28426

Merged
thomasjpfan merged 1 commit intoscikit-learn:mainfrom
adrinjalali:slep6/typo
Feb 15, 2024
Merged

REVERT DOC Fix typo - a better typo#28426
thomasjpfan merged 1 commit intoscikit-learn:mainfrom
adrinjalali:slep6/typo

Conversation

@adrinjalali
Copy link
Copy Markdown
Member

This in effect reverts #28424, which removed an intentional typo.

This PR changes the typo and adds more of a note to make sure future contributors don't "fix" the typo.

cc @thomasjpfan

@github-actions
Copy link
Copy Markdown

✔️ Linting Passed

All linting checks passed. Your pull request is in excellent shape! ☀️

Generated for commit: d7ce1c7. Link to the linter CI: here

Copy link
Copy Markdown
Member

@thomasjpfan thomasjpfan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah sorry, I was too quick in merging this one. Thanks for the quick fix and the added context.

@thomasjpfan thomasjpfan merged commit 720e4da into scikit-learn:main Feb 15, 2024
@adrinjalali adrinjalali deleted the slep6/typo branch February 15, 2024 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants