DOC Fix typos in doc of metadata requesting#28424
Merged
thomasjpfan merged 1 commit intoscikit-learn:mainfrom Feb 14, 2024
Merged
DOC Fix typos in doc of metadata requesting#28424thomasjpfan merged 1 commit intoscikit-learn:mainfrom
thomasjpfan merged 1 commit intoscikit-learn:mainfrom
Conversation
Signed-off-by: Adam Li <adam2392@gmail.com>
Member
|
The point of that paragraph is to demonstrate typos will be detected. It was an intentional typo. This PR needs to be reverted. |
Member
Author
|
Ah I see. Apologies. I misread the paragraph when reading. How is the best way to revert this? |
Member
|
Opened #28426 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Fixes typos. This should be a quick and easy review :)
What does this implement/fix? Explain your changes.
See: https://scikit-learn.org/stable/metadata_routing.html#:~:text=This%20guide%20demonstrates%20how%20metadata,the%20metadata%2C%20must%20request%20it.
Any other comments?