Skip to content

CI Add cron schedule for lock-file workflow#27732

Merged
betatim merged 1 commit intoscikit-learn:mainfrom
lesteve:cron-lock-file-bot
Nov 6, 2023
Merged

CI Add cron schedule for lock-file workflow#27732
betatim merged 1 commit intoscikit-learn:mainfrom
lesteve:cron-lock-file-bot

Conversation

@lesteve
Copy link
Copy Markdown
Member

@lesteve lesteve commented Nov 6, 2023

I ran manually the lock-file bot actions twice and it seems to have worked fine, see action runs and created PRs. The first run with failure was due to scikit-learn-bot permissions, see #27622 (comment) for more details.

I used a weekly cron job that runs every Monday at 5am (see this for double-checking the cron syntax). If we want to run it less often, we could run it every 1st and 15th of the month (there is no easy way to do every two weeks with cron)

I left the workflow_dispatch that can still be handy to trigger manually the workflow in some cases where we don't want to wait for the next scheduled job.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Nov 6, 2023

✔️ Linting Passed

All linting checks passed. Your pull request is in excellent shape! ☀️

Generated for commit: e761566. Link to the linter CI: here

@lesteve lesteve changed the title CI Add cron schedule for lock-file bot CI Add cron schedule for lock-file workflow Nov 6, 2023
@lesteve lesteve added No Changelog Needed Quick Review For PRs that are quick to review labels Nov 6, 2023
Copy link
Copy Markdown
Member

@glemaitre glemaitre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks @lesteve

@betatim betatim merged commit bed14db into scikit-learn:main Nov 6, 2023
@lesteve lesteve deleted the cron-lock-file-bot branch November 6, 2023 15:25
@lesteve
Copy link
Copy Markdown
Member Author

lesteve commented Nov 6, 2023

Nice, let's see what happens next Monday!

REDVM pushed a commit to REDVM/scikit-learn that referenced this pull request Nov 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants