DOC fixed wrong equation reference in adaboost docstring#27717
Merged
glemaitre merged 1 commit intoscikit-learn:mainfrom Nov 3, 2023
Merged
DOC fixed wrong equation reference in adaboost docstring#27717glemaitre merged 1 commit intoscikit-learn:mainfrom
glemaitre merged 1 commit intoscikit-learn:mainfrom
Conversation
Signed-off-by: Peter Steinbach <p.steinbach@hzdr.de>
glemaitre
approved these changes
Nov 3, 2023
REDVM
pushed a commit
to REDVM/scikit-learn
that referenced
this pull request
Nov 16, 2023
…n#27717) Signed-off-by: Peter Steinbach <p.steinbach@hzdr.de>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Already gave this a try using the github hosted web editor. This PR is more clean.
What does this implement/fix? Explain your changes.
Quite small contribution fixing the reference to the equation in
https://www.intlpress.com/site/pub/pages/journals/items/sii/content/vols/0002/0003/a008/
mentioned in the AdaBoost code base.
Any other comments?
The formula just below my edit reads a bit quirky compared to the paper (difference of
f_c(X)versusf_k(X)and how it relates to the paper). This might be improved in the future.