MAINT remove old code related to removed option max_features="auto"#27698
Merged
OmarManzoor merged 2 commits intoscikit-learn:mainfrom Nov 3, 2023
Merged
Conversation
lucyleeow
approved these changes
Nov 1, 2023
Member
lucyleeow
left a comment
There was a problem hiding this comment.
LGTM thanks!
Now that parameter constraints will not allow max_features to be 'auto' we could probably delete these lines:
scikit-learn/sklearn/tree/_classes.py
Lines 337 to 357 in 88dbd3b
sklearn/tree/_classes.py
Outdated
Comment on lines
+1523
to
+1524
| `max(1, int(max_features * n_features_in_))` features are considered at | ||
| each split. |
Member
There was a problem hiding this comment.
Does the indenting look off here? Should it align with 'If' in the line above?
Member
Author
|
Indeed. We probably make some merging when the coverage was not working because this code is not covered anymore. |
REDVM
pushed a commit
to REDVM/scikit-learn
that referenced
this pull request
Nov 16, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #27696
In scikit-learn 1.1, we deprecated
max_features="auto"in decision trees and we remove this option in scikit-learn 1.3. However, we forgot to remove some of the occurrences from some docstring.