ENH Add warning when only one label found in confusion_matrix#27650
Merged
OmarManzoor merged 4 commits intoscikit-learn:mainfrom Nov 3, 2023
Merged
ENH Add warning when only one label found in confusion_matrix#27650OmarManzoor merged 4 commits intoscikit-learn:mainfrom
confusion_matrix#27650OmarManzoor merged 4 commits intoscikit-learn:mainfrom
Conversation
glemaitre
reviewed
Oct 30, 2023
sklearn/metrics/_classification.py
Outdated
| if cm.shape == (1, 1): | ||
| warnings.warn( | ||
| ( | ||
| "Only one label was found in 'y_true' and 'y_pred', use the 'labels' " |
Member
There was a problem hiding this comment.
Suggested change
| "Only one label was found in 'y_true' and 'y_pred', use the 'labels' " | |
| "A single label is found in 'y_true' and 'y_pred', use the 'labels' " |
glemaitre
reviewed
Oct 30, 2023
Member
glemaitre
left a comment
There was a problem hiding this comment.
Could you also add an entry in the changelog and a non-regression test?
Per the discussion, the resolution is fine to me.
Thanks @lucyleeow
confusion_matrixconfusion_matrix
Member
Author
|
Done thank you @glemaitre ! |
OmarManzoor
approved these changes
Nov 3, 2023
Contributor
OmarManzoor
left a comment
There was a problem hiding this comment.
LGTM. Thanks @lucyleeow
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
fixes #19756
What does this implement/fix? Explain your changes.
Add warning when only one label found in
confusion_matrixand advise user to pass all labels vialabelsparameter.