Skip to content

DOC add dropdown menu for Section 2.5 Decomposing signals in components#27551

Merged
ArturoAmorQ merged 20 commits intoscikit-learn:mainfrom
kots14:fix-issue-26617-2.5
Dec 20, 2023
Merged

DOC add dropdown menu for Section 2.5 Decomposing signals in components#27551
ArturoAmorQ merged 20 commits intoscikit-learn:mainfrom
kots14:fix-issue-26617-2.5

Conversation

@kots14
Copy link
Copy Markdown
Contributor

@kots14 kots14 commented Oct 8, 2023

Update decomposition.rst with drop downs #26617

Reference Issues/PRs

Fixes 2.5. Decomposing signals in components (matrix factorization problems) from #26617

What does this implement/fix?

  • Added drop downs in decomposition.rst for documentation indicating the following sub-sections
    • Eigensolvers
    • About truncated SVD and latent semantic analysis(LSA)
    • More about implementation and usage of NMF
    • Details on modeling text corpora

@kots14
Update decomposition.rst
d2468c0 
Update decomposition.rst with drop downs scikit-learn#26617
@github-actions
Copy link
Copy Markdown

github-actions bot commented Oct 8, 2023 •
edited
Loading

✔️ Linting Passed

All linting checks passed. Your pull request is in excellent shape! ☀️

Generated for commit: b678e13. Link to the linter CI: here

@glemaitre glemaitre changed the title Update decomposition.rst DOC add dropdown menu for Section 2.5 Decomposing signals in components Oct 10, 2023
@ArturoAmorQ ArturoAmorQ mentioned this pull request Oct 11, 2023
Closed
54 tasks
ArturoAmorQ
ArturoAmorQ reviewed Nov 21, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@ArturoAmorQ ArturoAmorQ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @kots14, thanks for the PR and sorry for taking so long to answer. Here is a first batch of comments.

I think there are still some mathematical details in 2.5.5. Factor Analysis and 2.5.7.2. NMF with a beta-divergence that could be hidden, but may need a bit of tweaking the text. Just keep a brief description (one or two paragraphs) before the hidden mathematical details.

@kots14
Copy link
Copy Markdown
Contributor Author

kots14 commented Nov 22, 2023

Thanks @ArturoAmorQ for the review. I'll modify the PR.

kots14
kots14 commented Nov 26, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor Author

@kots14 kots14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Modified PR with the changes requested.

@kots14 kots14 requested a review from ArturoAmorQ November 26, 2023 16:05
ArturoAmorQ
ArturoAmorQ reviewed Nov 27, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@ArturoAmorQ ArturoAmorQ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the changes! The PR is getting in good shape :) here is another badge of comments.

kots14 and others added 3 commits November 28, 2023 19:56
@kots14 @ArturoAmorQ
Update doc/modules/decomposition.rst
9f2a9ba 
Co-authored-by: Arturo Amor <86408019+ArturoAmorQ@users.noreply.github.com>
@kots14 @ArturoAmorQ
Update doc/modules/decomposition.rst
eb11e9c 
Co-authored-by: Arturo Amor <86408019+ArturoAmorQ@users.noreply.github.com>
@kots14
Merge branch 'main' into fix-issue-26617-2.5
618cec3
@kots14
Copy link
Copy Markdown
Contributor Author

kots14 commented Dec 5, 2023

Sorry for the delay, I'll modify this PR by this week.

kots14
kots14 commented Dec 14, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor Author

@kots14 kots14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Modified the PR based on previous comments.

@kots14 kots14 requested a review from ArturoAmorQ December 14, 2023 15:26
ArturoAmorQ
ArturoAmorQ approved these changes Dec 20, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@ArturoAmorQ ArturoAmorQ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the delay @kots14, LGTM :) Merging!

@ArturoAmorQ ArturoAmorQ merged commit 281523c into scikit-learn:main Dec 20, 2023
@kots14 kots14 deleted the fix-issue-26617-2.5 branch December 21, 2023 14:39
jeremiedbb pushed a commit to jeremiedbb/scikit-learn that referenced this pull request Jan 17, 2024
@kots14 @jeremiedbb
DOC add dropdown menu for Section 2.5 Decomposing signals in componen…
e1bd6fd 
…ts (scikit-learn#27551)
jeremiedbb pushed a commit that referenced this pull request Jan 17, 2024
@kots14 @jeremiedbb
DOC add dropdown menu for Section 2.5 Decomposing signals in componen…
ebfe3cb 
…ts (#27551)
glemaitre pushed a commit to glemaitre/scikit-learn that referenced this pull request Feb 10, 2024
@kots14 @glemaitre
DOC add dropdown menu for Section 2.5 Decomposing signals in componen…
908bc24 
…ts (scikit-learn#27551)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ArturoAmorQ ArturoAmorQ ArturoAmorQ approved these changes

Assignees

No one assigned

Labels

Documentation

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@kots14 @ArturoAmorQ