Skip to content

TST Extend tests for scipy.sparse.*array in sklearn/manifold/tests/test_isomap.py#27341

Merged
OmarManzoor merged 1 commit intoscikit-learn:mainfrom
brendanlu:sparse1
Sep 13, 2023
Merged

TST Extend tests for scipy.sparse.*array in sklearn/manifold/tests/test_isomap.py#27341
OmarManzoor merged 1 commit intoscikit-learn:mainfrom
brendanlu:sparse1

Conversation

@brendanlu
Copy link
Copy Markdown
Contributor

Reference Issues/PRs

Towards #27090

What does this implement/fix? Explain your changes.

Wrapped matrix output from sparse_rand in CSR_CONTAINERS

@github-actions
Copy link
Copy Markdown

✔️ Linting Passed

All linting checks passed. Your pull request is in excellent shape! ☀️

Generated for commit: 15b886d. Link to the linter CI: here

@brendanlu brendanlu changed the title wrap sparse X in csr_container in test_isomap.py TST Extend tests for scipy.sparse.*array in sklearn/manifold/tests/test_isomap.py Sep 12, 2023
@glemaitre glemaitre self-requested a review September 13, 2023 09:52
Copy link
Copy Markdown
Member

@glemaitre glemaitre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @brendanlu.
Another easy one @OmarManzoor.

Copy link
Copy Markdown
Contributor

@OmarManzoor OmarManzoor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @brendanlu

@OmarManzoor OmarManzoor merged commit 6ca15ea into scikit-learn:main Sep 13, 2023
@brendanlu brendanlu deleted the sparse1 branch September 14, 2023 01:10
REDVM pushed a commit to REDVM/scikit-learn that referenced this pull request Nov 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants