Skip to content

MAINT cython typedefs in _cd_fast#27334

Merged
glemaitre merged 1 commit intoscikit-learn:mainfrom
lorentzenchr:mnt_cd_fast_cython_types
Sep 11, 2023
Merged

MAINT cython typedefs in _cd_fast#27334
glemaitre merged 1 commit intoscikit-learn:mainfrom
lorentzenchr:mnt_cd_fast_cython_types

Conversation

@lorentzenchr
Copy link
Copy Markdown
Member

Reference Issues/PRs

Related to #25572.

What does this implement/fix? Explain your changes.

Any other comments?

@github-actions
Copy link
Copy Markdown

✔️ Linting Passed

All linting checks passed. Your pull request is in excellent shape! ☀️

Generated for commit: 1e5894e. Link to the linter CI: here

Copy link
Copy Markdown
Contributor

@OmarManzoor OmarManzoor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @lorentzenchr

@glemaitre glemaitre self-requested a review September 11, 2023 15:36
@glemaitre glemaitre merged commit 8ed76c7 into scikit-learn:main Sep 11, 2023
@glemaitre
Copy link
Copy Markdown
Member

Thanks @lorentzenchr

@lorentzenchr lorentzenchr deleted the mnt_cd_fast_cython_types branch September 11, 2023 18:06
REDVM pushed a commit to REDVM/scikit-learn that referenced this pull request Nov 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants