MAINT better fused type names in loss module#27330
Merged
glemaitre merged 1 commit intoscikit-learn:mainfrom Sep 11, 2023
Merged
MAINT better fused type names in loss module#27330glemaitre merged 1 commit intoscikit-learn:mainfrom
glemaitre merged 1 commit intoscikit-learn:mainfrom
Conversation
Member
Author
|
Question: Let double be double or change to float64_t? I'm leaning more to letting double untouched. |
OmarManzoor
approved these changes
Sep 11, 2023
Contributor
OmarManzoor
left a comment
There was a problem hiding this comment.
LGTM. Thanks @lorentzenchr
Member
I would let as-is. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Related to #25572.