TST Extend tests for scipy.sparse.*array in sklearn\model_selection\tests\test_search.py#27326
Merged
glemaitre merged 3 commits intoscikit-learn:mainfrom Sep 11, 2023
Merged
Conversation
Member
|
I solved the merge conflict. @alxfgh It seems that you did not install pre-commit. You might want to install it such that you don't get any formatting issue in the future and the CI checking the linting will not fail. |
Member
|
I also trigger |
glemaitre
approved these changes
Sep 11, 2023
Member
glemaitre
left a comment
There was a problem hiding this comment.
If the CIs become green, then LGTM.
Member
|
|
OmarManzoor
approved these changes
Sep 11, 2023
Contributor
OmarManzoor
left a comment
There was a problem hiding this comment.
LGTM. Thanks @alxfgh
bncer
pushed a commit
to bncer/scikit-learn
that referenced
this pull request
Sep 13, 2023
…n\tests\test_search.py` (scikit-learn#27326) Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Towards #27090.