TST Extend tests for scipy.sparse.*array in sklearn/tests/test_kernel_approximation.py#27301
Conversation
scipy.sparse/*array in sklearn\tests\test_kernel_approximation.py and sklearn/utils/_testing.py
scipy.sparse/*array in sklearn\tests\test_kernel_approximation.py and sklearn/utils/_testing.pyscipy.sparse.*array in sklearn/tests/test_kernel_approximation.py and sklearn/utils/_testing.py
OmarManzoor
left a comment
There was a problem hiding this comment.
Thanks for the PR @lohitslohit. Is there a specific reason why we are including two files in the same PR?
|
@OmarManzoor No specific reason. I am new to open source. |
|
@lohitslohit In that case I think it would be suitable to treat each file in a separate PR as that is the format that is being followed with this meta issue. |
…sting.py" due to the duplicate file entry This reverts commit 3fc0fc4.
…to test-kernel-ap
scipy.sparse.*array in sklearn/tests/test_kernel_approximation.py and sklearn/utils/_testing.pyscipy.sparse.*array in sklearn/tests/test_kernel_approximation.py
|
Hi, Isn't this a duplicate of #27275? |
|
OK so I am closing it in preference of this PR. |
OmarManzoor
left a comment
There was a problem hiding this comment.
I think this one might require a change log as there is a change in the code.
glemaitre
left a comment
There was a problem hiding this comment.
LGTM on my side.
I added an entry in the changelog and launch the test for scipy-dev.
If the CIs become green, all good.
OmarManzoor
left a comment
There was a problem hiding this comment.
LGTM as well. Thanks @lohitslohit
|
@glemaitre I think the only tests that are failing are related to docs with the scipy-dev CI. CI pipeline link |
|
Indeed. The docstring failure will be always visible. Feel free to merge when it comes to this issue. |
…nel_approximation.py` (scikit-learn#27301) Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com> Co-authored-by: Omar Salman <omar.salman@arbisoft.com>
Reference Issues/PRs
Towards #27090.