TST Extend tests for scipy.sparse/*array in sklearn/utils/tests/test_testing#27276
Merged
glemaitre merged 6 commits intoscikit-learn:mainfrom Sep 12, 2023
Merged
TST Extend tests for scipy.sparse/*array in sklearn/utils/tests/test_testing#27276glemaitre merged 6 commits intoscikit-learn:mainfrom
scipy.sparse/*array in sklearn/utils/tests/test_testing#27276glemaitre merged 6 commits intoscikit-learn:mainfrom
Conversation
Contributor
|
@Charlie-XIAO I am new to open source, Can you help me to fix the issue in #27275. |
scipy.sparse/*array in sklearn/utils/tests/test_testing
OmarManzoor
approved these changes
Sep 6, 2023
Contributor
OmarManzoor
left a comment
There was a problem hiding this comment.
LGTM. Thanks @Charlie-XIAO. I think it doesn't hurt to have the checks for sparse arrays as well.
glemaitre
reviewed
Sep 11, 2023
glemaitre
reviewed
Sep 12, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Towards #27090.
I extended the
_convert_containerfunction a bit for the sparse arrays, please let me know if this is not necessary (in which case the tests for sparse arrays intest_convert_containerneed to be removed).