Skip to content

TST Extend tests for scipy.sparse/*array in sklearn/utils/tests/test_multiclass#27274

Merged
OmarManzoor merged 5 commits intoscikit-learn:mainfrom
Charlie-XIAO:tst_sp_multiclass
Sep 12, 2023
Merged

TST Extend tests for scipy.sparse/*array in sklearn/utils/tests/test_multiclass#27274
OmarManzoor merged 5 commits intoscikit-learn:mainfrom
Charlie-XIAO:tst_sp_multiclass

Conversation

@Charlie-XIAO
Copy link
Copy Markdown
Contributor

@Charlie-XIAO Charlie-XIAO commented Sep 3, 2023

Towards #27090.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Sep 3, 2023 •
edited
Loading

✔️ Linting Passed

All linting checks passed. Your pull request is in excellent shape! ☀️

Generated for commit: 5f33e08. Link to the linter CI: here

@jjerphan jjerphan mentioned this pull request Sep 3, 2023
Closed
OmarManzoor
OmarManzoor reviewed Sep 6, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@OmarManzoor OmarManzoor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Charlie-XIAO. I think this one might require a change log entry because it is changing the code to support spare arrays.

glemaitre
glemaitre reviewed Sep 11, 2023
View reviewed changes
glemaitre
glemaitre reviewed Sep 11, 2023
View reviewed changes
@glemaitre glemaitre self-requested a review September 11, 2023 17:57
glemaitre
glemaitre reviewed Sep 11, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@glemaitre glemaitre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise, it looks good.

@Charlie-XIAO
Copy link
Copy Markdown
Contributor Author

Charlie-XIAO commented Sep 12, 2023 •
edited
Loading

Thanks for the review @glemaitre, I think I have used [*l1, *l2] in all my other PRs. Seems that l1 + l2 is preferred, and I will make the changes ASAP. By the way, may I ask why this is preferred (maybe for readability)?

Update: Sorry this question seems to be a duplicate of #27262 (comment), please just ignore this.

@glemaitre
Copy link
Copy Markdown
Member

glemaitre commented Sep 12, 2023

By the way, may I ask why this is preferred (maybe for readability)?

I answer here: #27262 (comment). But the unpacking is not fundamentally wrong.

glemaitre
glemaitre approved these changes Sep 12, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@glemaitre glemaitre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Waiting for the CIs to turn green.

@glemaitre
Copy link
Copy Markdown
Member

glemaitre commented Sep 12, 2023

@OmarManzoor This one should be good to go.

OmarManzoor
OmarManzoor approved these changes Sep 12, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@OmarManzoor OmarManzoor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @Charlie-XIAO

@OmarManzoor OmarManzoor merged commit 18a13f2 into scikit-learn:main Sep 12, 2023
@Charlie-XIAO Charlie-XIAO deleted the tst_sp_multiclass branch September 12, 2023 12:15
REDVM pushed a commit to REDVM/scikit-learn that referenced this pull request Nov 16, 2023
@Charlie-XIAO @REDVM
TST Extend tests for scipy.sparse/*array in `sklearn/utils/tests/te…
4f02b60 
…st_multiclass` (scikit-learn#27274)
@adrinjalali adrinjalali mentioned this pull request Apr 15, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@glemaitre glemaitre glemaitre approved these changes

@OmarManzoor OmarManzoor OmarManzoor approved these changes

Assignees

No one assigned

Labels

module:utils

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Charlie-XIAO @glemaitre @OmarManzoor