TST Extend tests for scipy.sparse/*array in sklearn/tree/tests/test_tree#27261
Merged
OmarManzoor merged 13 commits intoscikit-learn:mainfrom Sep 13, 2023
Merged
TST Extend tests for scipy.sparse/*array in sklearn/tree/tests/test_tree#27261OmarManzoor merged 13 commits intoscikit-learn:mainfrom
scipy.sparse/*array in sklearn/tree/tests/test_tree#27261OmarManzoor merged 13 commits intoscikit-learn:mainfrom
Conversation
glemaitre
reviewed
Sep 12, 2023
glemaitre
reviewed
Sep 12, 2023
glemaitre
reviewed
Sep 12, 2023
glemaitre
reviewed
Sep 12, 2023
Member
|
Otherwise, it looks good. Thanks for the refactoring as well. I think this is nice to avoid the two level functions. |
Contributor
Author
|
Trying to resolve CI now... |
glemaitre
reviewed
Sep 12, 2023
glemaitre
approved these changes
Sep 13, 2023
Member
glemaitre
left a comment
There was a problem hiding this comment.
Nice. The CIs are passing now. Thanks @Charlie-XIAO. LGTM
Member
|
This one is also ready @OmarManzoor |
OmarManzoor
reviewed
Sep 13, 2023
Contributor
OmarManzoor
left a comment
There was a problem hiding this comment.
Thanks @Charlie-XIAO. Just some minor comments otherwise LGTM.
Contributor
Author
|
Done @OmarManzoor, I double checked the unpacking stuff but completed missed this PR, thanks for pointing out! |
OmarManzoor
approved these changes
Sep 13, 2023
Contributor
OmarManzoor
left a comment
There was a problem hiding this comment.
LGTM. Thanks @Charlie-XIAO
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Towards #27090.