TST Extend tests for scipy.sparse/*array in sklearn/neural_network/tests/test_rbm#27252
Merged
OmarManzoor merged 7 commits intoscikit-learn:mainfrom Sep 13, 2023
Merged
TST Extend tests for scipy.sparse/*array in sklearn/neural_network/tests/test_rbm#27252OmarManzoor merged 7 commits intoscikit-learn:mainfrom
scipy.sparse/*array in sklearn/neural_network/tests/test_rbm#27252OmarManzoor merged 7 commits intoscikit-learn:mainfrom
Conversation
Member
|
We will need a changelog as an enhancement since we change the code of |
glemaitre
reviewed
Sep 12, 2023
Member
glemaitre
left a comment
There was a problem hiding this comment.
Otherwise, LGTM. We will still need an enhancement entry in the changelog because it would not work currently.
Contributor
Author
|
Done, thanks for the suggestions @glemaitre. |
glemaitre
reviewed
Sep 12, 2023
Member
glemaitre
left a comment
There was a problem hiding this comment.
Too fast, there is still a failure. I assume this is for an old scipy version. I have to check a bit more.
glemaitre
reviewed
Sep 12, 2023
glemaitre
approved these changes
Sep 13, 2023
Member
glemaitre
left a comment
There was a problem hiding this comment.
Thanks @Charlie-XIAO LGTM. @OmarManzoor this is also ready/
OmarManzoor
approved these changes
Sep 13, 2023
Contributor
OmarManzoor
left a comment
There was a problem hiding this comment.
LGTM. Thanks @Charlie-XIAO
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Towards #27090.