Skip to content

TST Extend tests for scipy.sparse/*array in sklearn/model_selection/tests/test_split#27246

Merged
OmarManzoor merged 3 commits intoscikit-learn:mainfrom
Charlie-XIAO:tst_sp_split
Sep 13, 2023
Merged

TST Extend tests for scipy.sparse/*array in sklearn/model_selection/tests/test_split#27246
OmarManzoor merged 3 commits intoscikit-learn:mainfrom
Charlie-XIAO:tst_sp_split

Conversation

@Charlie-XIAO
Copy link
Copy Markdown
Contributor

Towards #27090.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Aug 31, 2023

✔️ Linting Passed

All linting checks passed. Your pull request is in excellent shape! ☀️

Generated for commit: 9e619ca. Link to the linter CI: here

Copy link
Copy Markdown
Member

@glemaitre glemaitre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise LGTM.

Copy link
Copy Markdown
Member

@glemaitre glemaitre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise LGTM.

@glemaitre
Copy link
Copy Markdown
Member

Easy one to be merged @OmarManzoor

Copy link
Copy Markdown
Contributor

@OmarManzoor OmarManzoor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @Charlie-XIAO

@OmarManzoor OmarManzoor merged commit db9fe15 into scikit-learn:main Sep 13, 2023
@Charlie-XIAO Charlie-XIAO deleted the tst_sp_split branch September 13, 2023 14:41
REDVM pushed a commit to REDVM/scikit-learn that referenced this pull request Nov 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants