Skip to content

TST Extend tests for scipy.sparse/*array in sklearn/linear_model/tests/test_sparse_coordinate_descent#27237

Merged
glemaitre merged 4 commits intoscikit-learn:mainfrom
Charlie-XIAO:tst_sp_sparse_coordinate_descent
Sep 13, 2023
Merged

TST Extend tests for scipy.sparse/*array in sklearn/linear_model/tests/test_sparse_coordinate_descent#27237
glemaitre merged 4 commits intoscikit-learn:mainfrom
Charlie-XIAO:tst_sp_sparse_coordinate_descent

Conversation

@Charlie-XIAO
Copy link
Copy Markdown
Contributor

Towards #27090.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Aug 30, 2023

✔️ Linting Passed

All linting checks passed. Your pull request is in excellent shape! ☀️

Generated for commit: 50af53c. Link to the linter CI: here

Copy link
Copy Markdown
Member

@glemaitre glemaitre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@glemaitre
Copy link
Copy Markdown
Member

An easy one @OmarManzoor :)

Copy link
Copy Markdown
Contributor

@OmarManzoor OmarManzoor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @Charlie-XIAO

@glemaitre glemaitre enabled auto-merge (squash) September 13, 2023 12:17
@glemaitre glemaitre merged commit 44ef975 into scikit-learn:main Sep 13, 2023
@Charlie-XIAO Charlie-XIAO deleted the tst_sp_sparse_coordinate_descent branch September 13, 2023 14:39
REDVM pushed a commit to REDVM/scikit-learn that referenced this pull request Nov 16, 2023
…ests/test_sparse_coordinate_descent` (scikit-learn#27237)

Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants