Skip to content

TST Extend tests for scipy.sparse.*array in sklearn/tests/test_multiclass.py#27223

Merged
glemaitre merged 5 commits intoscikit-learn:mainfrom
Tialo:tests/test_multiclass
Sep 13, 2023
Merged

TST Extend tests for scipy.sparse.*array in sklearn/tests/test_multiclass.py#27223
glemaitre merged 5 commits intoscikit-learn:mainfrom
Tialo:tests/test_multiclass

Conversation

@Tialo
Copy link
Copy Markdown
Contributor

@Tialo Tialo commented Aug 30, 2023

Reference Issues/PRs

Towards #27090.

What does this implement/fix? Explain your changes.

Any other comments?

@github-actions
Copy link
Copy Markdown

github-actions bot commented Aug 30, 2023

✔️ Linting Passed

All linting checks passed. Your pull request is in excellent shape! ☀️

Generated for commit: 97bda70. Link to the linter CI: here

Copy link
Copy Markdown
Contributor

@OmarManzoor OmarManzoor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @Tialo. Just some minor comments otherwise looks LGTM.

Tialo and others added 3 commits September 1, 2023 13:38
Co-authored-by: Omar Salman <omar.salman@arbisoft.com>
Co-authored-by: Omar Salman <omar.salman@arbisoft.com>
Co-authored-by: Omar Salman <omar.salman@arbisoft.com>
@glemaitre glemaitre self-requested a review September 13, 2023 13:07
Copy link
Copy Markdown
Member

@glemaitre glemaitre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @Tialo. Merging.

@glemaitre glemaitre merged commit 749136e into scikit-learn:main Sep 13, 2023
@Tialo Tialo deleted the tests/test_multiclass branch September 13, 2023 14:49
REDVM pushed a commit to REDVM/scikit-learn that referenced this pull request Nov 16, 2023
…ticlass.py` (scikit-learn#27223)

Co-authored-by: Omar Salman <omar.salman@arbisoft.com>
Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants