Skip to content

TST Extend tests for scipy.sparse.*array in sklearn/manifold/tests/test_t_sne.py#27221

Merged
glemaitre merged 2 commits intoscikit-learn:mainfrom
Tialo:tests/test_t_sne
Sep 13, 2023
Merged

TST Extend tests for scipy.sparse.*array in sklearn/manifold/tests/test_t_sne.py#27221
glemaitre merged 2 commits intoscikit-learn:mainfrom
Tialo:tests/test_t_sne

Conversation

@Tialo
Copy link
Copy Markdown
Contributor

@Tialo Tialo commented Aug 30, 2023

Reference Issues/PRs

Towards #27090.

What does this implement/fix? Explain your changes.

Any other comments?

If there is the better way to parameterise test test_bad_precomputed_distances, I will fix it.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Aug 30, 2023

✔️ Linting Passed

All linting checks passed. Your pull request is in excellent shape! ☀️

Generated for commit: d01046d. Link to the linter CI: here

Copy link
Copy Markdown
Contributor

@OmarManzoor OmarManzoor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @Tialo

Copy link
Copy Markdown
Member

@glemaitre glemaitre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just parametrize a couple of occurrences that locally converted or imported sparse matrices.

@glemaitre
Copy link
Copy Markdown
Member

Enabling the auto-merge

@glemaitre glemaitre merged commit 0169bde into scikit-learn:main Sep 13, 2023
@Tialo Tialo deleted the tests/test_t_sne branch September 13, 2023 17:37
REDVM pushed a commit to REDVM/scikit-learn that referenced this pull request Nov 16, 2023
…/test_t_sne.py` (scikit-learn#27221)

Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants