Skip to content

TST Extend tests for scipy.sparse.*array in sklearn/metrics/tests/test_ranking.py#27212

Merged
glemaitre merged 2 commits intoscikit-learn:mainfrom
Tialo:tests/test_ranking
Sep 13, 2023
Merged

TST Extend tests for scipy.sparse.*array in sklearn/metrics/tests/test_ranking.py#27212
glemaitre merged 2 commits intoscikit-learn:mainfrom
Tialo:tests/test_ranking

Conversation

@Tialo
Copy link
Copy Markdown
Contributor

@Tialo Tialo commented Aug 29, 2023

Reference Issues/PRs

Towards #27090.

What does this implement/fix? Explain your changes.

Any other comments?

@github-actions
Copy link
Copy Markdown

github-actions bot commented Aug 29, 2023

✔️ Linting Passed

All linting checks passed. Your pull request is in excellent shape! ☀️

Generated for commit: 0dba3e5. Link to the linter CI: here

Copy link
Copy Markdown
Contributor

@OmarManzoor OmarManzoor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @Tialo

@glemaitre glemaitre self-requested a review September 13, 2023 18:47
Copy link
Copy Markdown
Member

@glemaitre glemaitre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @Tialo

Merging.

@glemaitre glemaitre merged commit 1d51c2e into scikit-learn:main Sep 13, 2023
@Tialo Tialo deleted the tests/test_ranking branch September 13, 2023 19:16
REDVM pushed a commit to REDVM/scikit-learn that referenced this pull request Nov 16, 2023
…test_ranking.py` (scikit-learn#27212)

Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants