Skip to content

TST Extend tests for scipy.sparse.*array in sklearn/linear_model/tests/test_logistic.py#27210

Merged
glemaitre merged 2 commits intoscikit-learn:mainfrom
Tialo:tests/test_logistic
Sep 13, 2023
Merged

TST Extend tests for scipy.sparse.*array in sklearn/linear_model/tests/test_logistic.py#27210
glemaitre merged 2 commits intoscikit-learn:mainfrom
Tialo:tests/test_logistic

Conversation

@Tialo
Copy link
Copy Markdown
Contributor

@Tialo Tialo commented Aug 29, 2023

Reference Issues/PRs

Towards #27090.

What does this implement/fix? Explain your changes.

Any other comments?

@github-actions
Copy link
Copy Markdown

github-actions bot commented Aug 29, 2023

✔️ Linting Passed

All linting checks passed. Your pull request is in excellent shape! ☀️

Generated for commit: fbcde5c. Link to the linter CI: here

Copy link
Copy Markdown
Contributor

@OmarManzoor OmarManzoor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @Tialo

@glemaitre glemaitre self-requested a review September 13, 2023 19:36
Copy link
Copy Markdown
Member

@glemaitre glemaitre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @Tialo

I modify one of the test that was created a sparse CSR random matrix.
It is nice to be sure that it works (or not) with large indices also for sparse arrays.

@glemaitre glemaitre enabled auto-merge (squash) September 13, 2023 19:43
@glemaitre glemaitre merged commit ea3e176 into scikit-learn:main Sep 13, 2023
@Tialo Tialo deleted the tests/test_logistic branch September 13, 2023 21:24
REDVM pushed a commit to REDVM/scikit-learn that referenced this pull request Nov 16, 2023
…ests/test_logistic.py` (scikit-learn#27210)

Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants