TST Extend tests for scipy.sparse.*array in sklearn/linear_model/tests/test_sag.py#27206
Merged
glemaitre merged 1 commit intoscikit-learn:mainfrom Sep 13, 2023
Merged
TST Extend tests for scipy.sparse.*array in sklearn/linear_model/tests/test_sag.py#27206glemaitre merged 1 commit intoscikit-learn:mainfrom
scipy.sparse.*array in sklearn/linear_model/tests/test_sag.py#27206glemaitre merged 1 commit intoscikit-learn:mainfrom
Conversation
Contributor
Author
|
Take a glance at the comment which I mentioned in PR title message @glemaitre |
Member
Contributor
Author
|
@glemaitre Yes, it says that those lines should be uncommented, as #4710 will be merged, so I thought maybe it is time. |
Contributor
Author
|
*not merged, but resolved |
Member
|
We could open a PR and try to see if it pass. |
Contributor
Author
|
I will work on it tomorrow, if it is okay @glemaitre |
Member
Whenever you fill like it :). You can ping my GitHub handle such that it falls under my radar. |
REDVM
pushed a commit
to REDVM/scikit-learn
that referenced
this pull request
Nov 16, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Towards #27090.
What does this implement/fix? Explain your changes.
Any other comments?
I noticed some comments in code that should be undone when #4710 will be done.
https://github.com/scikit-learn/scikit-learn/blob/main/sklearn/linear_model/tests/test_sag.py#L496