TST Extend tests for scipy.sparse.*array in sklearn/utils/tests/test_class_weight.py#27188
Merged
OmarManzoor merged 2 commits intoscikit-learn:mainfrom Aug 28, 2023
Merged
Conversation
yuanx749
commented
Aug 28, 2023
Comment on lines
+160
to
+165
| if sparse.issparse(y): | ||
| # Ok to densify a single column at a time | ||
| y_full = y_full.toarray().flatten() | ||
| # 1D sparse slices not yet implemented | ||
| y_full = y[:, [k]].toarray().flatten() | ||
| else: | ||
| y_full = y[:, k] |
Contributor
Author
There was a problem hiding this comment.
I changed the source code in this way because:
y[:, k]raisesNotImplementedErrorfor sparse array.- But for dense array,
y[:, [k]]results in 2D array and break other tests.
Member
There was a problem hiding this comment.
Looks good to me for now. If we have to repeat this pattern several times in other PRs, we should factorize this as a utility function somewhere under sklearn.utils.
Co-authored-by: Olivier Grisel <olivier.grisel@ensta.org>
OmarManzoor
approved these changes
Aug 28, 2023
Contributor
OmarManzoor
left a comment
There was a problem hiding this comment.
LGTM. Thanks @yuanx749
glemaitre
pushed a commit
to glemaitre/scikit-learn
that referenced
this pull request
Aug 29, 2023
…st_class_weight.py` (scikit-learn#27188)
REDVM
pushed a commit
to REDVM/scikit-learn
that referenced
this pull request
Nov 16, 2023
…st_class_weight.py` (scikit-learn#27188)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Towards #27090.
Reference Issues/PRs
What does this implement/fix? Explain your changes.
Any other comments?