Skip to content

TST Extend tests for scipy.sparse.*array in sklearn/cluster/tests/test_k_means.py#27179

Merged
OmarManzoor merged 13 commits intoscikit-learn:mainfrom
bncer:tst-k-means
Oct 2, 2023
Merged

TST Extend tests for scipy.sparse.*array in sklearn/cluster/tests/test_k_means.py#27179
OmarManzoor merged 13 commits intoscikit-learn:mainfrom
bncer:tst-k-means

Conversation

@bncer
Copy link
Copy Markdown
Contributor

@bncer bncer commented Aug 26, 2023

Reference Issues/PRs

Towards #27090

What does this implement/fix? Explain your changes.

This PR should support scipy.sparse.*array in cluster.kmeans_plusplus module.

Added tests cases of scipy's sparse array into sklearn/cluster/tests/test_k_means.py file

Any other comments?

Nope

@github-actions
Copy link
Copy Markdown

github-actions bot commented Aug 26, 2023 •
edited
Loading

✔️ Linting Passed

All linting checks passed. Your pull request is in excellent shape! ☀️

Generated for commit: 8a44d43. Link to the linter CI: here

@jjerphan jjerphan mentioned this pull request Aug 27, 2023
Closed
ogrisel
ogrisel reviewed Sep 11, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@ogrisel ogrisel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. Please consider the following naming suggestion. I did not made suggestions everywhere because it was getting tedious to do it all view the GitHub web UI but I would rather avoid using _container in variable names both to describe the name of the data type or constructor on the one hand (as used in other similar PRs) and the name of the data variable that results from this conversion.

You can take inspirations from my suggestions to resolve this ambiguity but this should be done systematically throughout the PR.

@bncer
Copy link
Copy Markdown
Contributor Author

bncer commented Sep 11, 2023

@ogrisel Thank you a lot! I will notify you when I finish naming issues.

@glemaitre glemaitre self-requested a review September 13, 2023 20:31
glemaitre
glemaitre reviewed Sep 13, 2023
View reviewed changes
glemaitre
glemaitre approved these changes Sep 13, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@glemaitre glemaitre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apart from those small changes, LGTM.

bncer and others added 11 commits September 14, 2023 21:57
@bncer
TST add sparse array to k means
534b79e 
Signed-off-by: Nurseit Kamchyev <bncer.ml@gmail.com>
@bncer
Add pr number in doc
11598e8 
Signed-off-by: Nurseit Kamchyev <bncer.ml@gmail.com>
@bncer @ogrisel
Update doc/whats_new/v1.4.rst
33a3162 
Co-authored-by: Olivier Grisel <olivier.grisel@ensta.org>
@bncer @ogrisel
rename data_containers and data_containers_ids for pytest.params
8b97e15 
Co-authored-by: Olivier Grisel <olivier.grisel@ensta.org>
@bncer
rename data_containers and data_containers_ids
b99db99
@bncer
input_data name for data
890a69b 
Signed-off-by: Nurseit Kamchyev <bncer.ml@gmail.com>
@bncer
Change X_container to array_constr
eae81ec 
Signed-off-by: Nurseit Kamchyev <bncer.ml@gmail.com>
@bncer @glemaitre
Update sklearn/cluster/tests/test_k_means.py
3a5c5c9 
Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com>
@bncer @glemaitre
Update sklearn/cluster/tests/test_k_means.py
a618d6f 
Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com>
@bncer @glemaitre
Update sklearn/cluster/tests/test_k_means.py
02167eb 
Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com>
@bncer
Update test_k_means.py
8b9bfb9
@bncer
array_constr var in one line
af44cdd 
Signed-off-by: Nurseit Kamchyev <bncer.ml@gmail.com>
@bncer
Copy link
Copy Markdown
Contributor Author

bncer commented Sep 14, 2023

@ogrisel please, take a look on changes

@glemaitre glemaitre self-requested a review September 29, 2023 20:59
glemaitre
glemaitre approved these changes Sep 29, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@glemaitre glemaitre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I solved the conflict in the what's new.
@OmarManzoor do you want to have a second look.

@glemaitre glemaitre added the Waiting for Second Reviewer First reviewer is done, need a second one! label Sep 29, 2023
OmarManzoor
OmarManzoor approved these changes Oct 2, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@OmarManzoor OmarManzoor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @bncer

@OmarManzoor OmarManzoor merged commit 335c2d2 into scikit-learn:main Oct 2, 2023
REDVM pushed a commit to REDVM/scikit-learn that referenced this pull request Nov 16, 2023
@bncer @REDVM
TST Extend tests for scipy.sparse.*array in `sklearn/cluster/tests/…
51b65f7 
…test_k_means.py` (scikit-learn#27179)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ogrisel ogrisel ogrisel left review comments

@glemaitre glemaitre glemaitre approved these changes

@OmarManzoor OmarManzoor OmarManzoor approved these changes

Assignees

No one assigned

Labels

module:cluster Waiting for Second Reviewer First reviewer is done, need a second one!

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@bncer @ogrisel @glemaitre @OmarManzoor