Skip to content

TST Extend tests for scipy.sparse.*array in sklearn/feature_selection/tests/test_mutual_info.py#27173

Merged
ogrisel merged 6 commits intoscikit-learn:mainfrom
brendanlu:main
Sep 11, 2023
Merged

TST Extend tests for scipy.sparse.*array in sklearn/feature_selection/tests/test_mutual_info.py#27173
ogrisel merged 6 commits intoscikit-learn:mainfrom
brendanlu:main

Conversation

@brendanlu
Copy link
Copy Markdown
Contributor

Reference Issues/PRs

Towards #27090.

What does this implement/fix? Explain your changes.

Decorate test_mutual_info_options to conditionally test sparse array.

@github-actions
Copy link
Copy Markdown

✔️ Linting Passed

All linting checks passed. Your pull request is in excellent shape! ☀️

Generated for commit: 2a4022f. Link to the linter CI: here

Copy link
Copy Markdown
Contributor

@work-mohit work-mohit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Good work @brendanlu

Copy link
Copy Markdown
Contributor

@OmarManzoor OmarManzoor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @brendanlu

Copy link
Copy Markdown
Member

@ogrisel ogrisel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ogrisel ogrisel merged commit 8d48624 into scikit-learn:main Sep 11, 2023
REDVM pushed a commit to REDVM/scikit-learn that referenced this pull request Nov 16, 2023
…ion/tests/test_mutual_info.py` (scikit-learn#27173)

Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants